Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable edge-to-edge in the demo application #658

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Enable edge-to-edge in the demo application #658

merged 2 commits into from
Jul 30, 2024

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented Jul 29, 2024 •
edited
Loading

Pull request

Description

This PR enables edge-to-edge in the demo application. This makes the status bar and navigation bar more integrated in the design of the app.

Screenshots

Light mode Dark mode
Screenshot_20240729_172400 Screenshot_20240729_172352

Changes made

  • Enable edge-to-edge.
  • Adjust SimplePlayerActivity so it does not go behind the status bar.
  • Disable the default inset on the search bar.
  • Remove manual status bar color management.
  • Add XML theme for dark mode.
  • Fix some typos.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 self-assigned this Jul 29, 2024
@MGaetan89 MGaetan89 added this to the Demo milestone Jul 29, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 29, 2024 •
edited
Loading

Code Coverage

Overall Project 48.77% 🟢

There is no coverage information present for the Files changed

@StaehliJ StaehliJ force-pushed the enable_edge_to_edge branch 2 times, most recently from 5b03c69 to 71403e8 Compare July 30, 2024 07:38
@MGaetan89 MGaetan89 force-pushed the enable_edge_to_edge branch from 0c23fef to 8ebe7ae Compare July 30, 2024 07:43
@MGaetan89 MGaetan89 added this pull request to the merge queue Jul 30, 2024
Merged via the queue into main with commit 7804a9a Jul 30, 2024
10 checks passed
@MGaetan89 MGaetan89 deleted the enable_edge_to_edge branch July 30, 2024 08:07
@MGaetan89 MGaetan89 mentioned this pull request Nov 4, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StaehliJ StaehliJ StaehliJ approved these changes

Assignees

@MGaetan89 MGaetan89

Labels
None yet
Projects
Pillarbox
Status: ✅ Done
Milestone
Demo
Development

Successfully merging this pull request may close these issues.
2 participants
@MGaetan89 @StaehliJ