Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly forward MediaPeriod.Callback with PillarboxMediaPeriod. #861

Merged
merged 3 commits into from
Jan 20, 2025
Merged

Correctly forward MediaPeriod.Callback with PillarboxMediaPeriod. #861

merged 3 commits into from
Jan 20, 2025

Conversation

StaehliJ
Copy link
Contributor

Pull request

Description

The goal of this PR is to improve MediaPeriod.Callback when using PillarboxMediaPeriod.

Changes made

  • Now MediaPeriod.Callback call it's callback with the right MediaPeriodtype.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 17, 2025 •
edited
Loading

Code Coverage

Overall Project 52.06% 🟢
Files changed 100% 🟢

Module Coverage
:pillarbox-player 57.37% 🟢
Files
Module File Coverage
:pillarbox-player PillarboxMediaPeriod.kt 100% 🟢

@MGaetan89
Copy link
Member

Should we add a test to PillarboxMediaPeriodTest to ensure that we receive the PillarboxMediaPeriod in the callback?

@MGaetan89 MGaetan89 enabled auto-merge January 20, 2025 09:27
@MGaetan89 MGaetan89 added this pull request to the merge queue Jan 20, 2025
auto-merge was automatically disabled January 20, 2025 09:43

Pull Request is not mergeable

Merged via the queue into main with commit 84f40b1 Jan 20, 2025
9 checks passed
@MGaetan89 MGaetan89 deleted the forward_media_period_callback branch January 20, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGaetan89 MGaetan89 MGaetan89 approved these changes

Assignees

@StaehliJ StaehliJ

Labels
None yet
Projects
Pillarbox
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StaehliJ @MGaetan89