Upgrade to .NET MAUI #451
Merged
Upgrade to .NET MAUI #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚧 Replaced EventToCommand to use MCT 💚 First Successful build
Renaming Namespaces Login Flow workaround
Added inits for SkiaSharp and BarcodeReader
Added Auth Handler Refactored Services Updated MauiProgram More namespace renamed Updated AndroidManifest
🚧Working on camera permissions
Change Camera stream to byte[] Update Android Target framework
Changed messaging subscription in profile viewmodel
… at this time Maui.Graphics is still marked as experimental. Keeping commented control for reference for when MG leaves experimerntal status.
NOTE: Scrolling views (eg CollectionView or ScrollView) won't scroll inside a stack layout in .NET MAUI.
NOTE: Scrolling views (eg CollectionView or ScrollView) won't scroll inside a stack layout in .NET MAUI.
Fixed linksocial entry Added white cursor to borderless entry on Android
Added delete profile to shell menu
Bump Android target version Remove duplicate icon resource
matt-goldman
requested review from
wicksipedia,
adamcogan,
william-liebenberg,
bradystroud,
JackDevAU,
lukecookssw and
AntPolkanov
AntPolkanov
approved these changes
Sep 29, 2023
JackDevAU
approved these changes
Sep 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change
SSW.Rewards was originally built with Xamarin.Forms in 2019. Xamarin.Forms is end of life after May 2024, so we needed to upgrade this to .NET MAUI to remain supported.
Relates to #169
As per my conversation with @adamcogan, the upgrade to .NET MAUI was approved and necessary.
Based on email thread, subject "SSW Rewards on MAUI" (from @william-liebenberg, cc @JackDevAU, @AntPolkanov, @adamcogan), we will collapse the 3 SSW Rewards repos (
SSW.Rewards.Admin,SSW.Rewards.API,SSW.Rewards.Mobile) into a single repo (this one).In preparation for this, this PR cleans up the repo and removes anything not related to the mobile app (as they will be brought in from the other repos).
SUMMARY OF CHANGES
src/SSW.Rewards.Androidfoldersrc/SSW.Rewards.iOSfoldersrc/SSW.Rewardsfolder to be the new .NET MAUI single-project solutionSSW.Rewards.slnto just include the single projectNote that this PR supersedes this one: #406
As this includes a significant change and required a substantial rebase, it's prudent to keep that draft PR and its corresponding branch (
upgrade-to-maui-v2) for 6 months for reference in case we encounter any issues following this merge.Tip for viewing the changed files
As this PR includes several hundred files, it is difficult to easily view the changes. Additionally, it can easily overwhelm your browser (see comment from @JackDevAU below). One way to get around this is to use the file filter:
Figure: The file filter let's you exclude certain file types from the comparison
My recommendation is to:
This should give you a good view of the material changes made to the code in this PR.