-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simple smoke test building drbd using the kernel-module-container #316
Conversation
012bfc0
to
61c1feb
Compare
I think you can mark it ready for review, this looks fine. |
42511a8
to
207b092
Compare
f778994
to
97ee60f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally lgtm, thanks a lot. just don't want to add any further exceptions to the BCI repo test..
97ee60f
to
a854904
Compare
a854904
to
e4335ad
Compare
1e71f60
to
48e95bf
Compare
48e95bf
to
63be77b
Compare
63be77b
to
06b5a1d
Compare
06b5a1d
to
362bcb5
Compare
362bcb5
to
cb6896d
Compare
09eb0e8
to
c7f148a
Compare
c7f148a
to
d487481
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small suggestion, otherwise LGTM.
if ( | ||
c | ||
not in ( | ||
[ | ||
INIT_CONTAINER, | ||
PCP_CONTAINER, | ||
# kernel-module-container contains systemd due to pesign, | ||
# fixes are pending | ||
KERNEL_MODULE_CONTAINER, | ||
] | ||
+ POSTGRESQL_CONTAINERS | ||
) | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would use a set here like this:
if ( | |
c | |
not in ( | |
[ | |
INIT_CONTAINER, | |
PCP_CONTAINER, | |
# kernel-module-container contains systemd due to pesign, | |
# fixes are pending | |
KERNEL_MODULE_CONTAINER, | |
] | |
+ POSTGRESQL_CONTAINERS | |
) | |
) | |
if c not in {INIT_CONTAINERS, PCP_CONTAINER, KERNEL_MODULE_CONTAINER} | {POSTGRESQL_CONTAINERS} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ricardobranco777 this isn't working (and there is a typo INIT_CONTAINERS->INIT_CONTAINER) because we're mixing sets and lists here (e.g. postgresql_containers is a list, so {[1,2,3]} gives
>>> {[1,2,3]}
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
TypeError: unhashable type: 'list'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ricardobranco777 this isn't working (and there is a typo INIT_CONTAINERS->INIT_CONTAINER) because we're mixing sets and lists here (e.g. postgresql_containers is a list, so {[1,2,3]} gives
>>> {[1,2,3]} Traceback (most recent call last): File "<stdin>", line 1, in <module> TypeError: unhashable type: 'list'
You can use set(POSTGRESQL_CONTAINERS)
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ricardobranco777 same issue:
tests/test_all.py:298: in <listcomp>
{
<string>:3: in __hash__
???
E TypeError: unhashable type: 'list'
I don't have time to debug this right now. lets take this into a followup PR.
d487481
to
67371fa
Compare
Also add docstrings to not lower the code health index
67371fa
to
81c560c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add simple smoke test building drbd using the kernel-module-container
No description provided.