Ensure that the branding packages are installed in the containers #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcermak
reviewed
Oct 24, 2023
dirkmueller
force-pushed
the
check_branding
branch
2 times, most recently
from
3dce36c to
5583f43
Compare
dirkmueller
force-pushed
the
check_branding
branch
2 times, most recently
from
4981986 to
d36a75b
Compare
dirkmueller
force-pushed
the
check_branding
branch
from
d36a75b to
05c629a
Compare
dirkmueller
force-pushed
the
check_branding
branch
2 times, most recently
from
51a383a to
d3e6fd2
Compare
dcermak
reviewed
Dec 7, 2023
| ) | ||
| def test_branding(container): | ||
| """ | ||
| check that the :file:`/etc/SUSE-brand` file exists and containers SLE branding |
There was a problem hiding this comment.
Suggested change
| check that the :file:`/etc/SUSE-brand` file exists and containers SLE branding | |
| check that the :file:`/etc/SUSE-brand` file exists and contains the SLE branding |
dcermak
reviewed
Dec 7, 2023
Comment on lines
+107
to
+110
| if OS_VERSION == "tumbleweed": | ||
| branding = "openSUSE" | ||
| if OS_VERSION in ("basalt", "tumbleweed"): | ||
| location = "/usr/etc/SUSE-brand" |
There was a problem hiding this comment.
Why use these switches when the tests only run on Tumbleweed?
There was a problem hiding this comment.
it also runs on 15.6 (and it did until recently basalt completely exploded) also on basalt. eventually I hope to be able to fix it also for older versions, so the skipif will reduce over time (famous last words)
dirkmueller
force-pushed
the
check_branding
branch
from
d3e6fd2 to
cb5091f
Compare
rcmadhankumar
pushed a commit
that referenced
this pull request
Aug 30, 2024
Ensure that the branding packages are installed in the containers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.