Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial testing for the mariadb container #354

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Initial testing for the mariadb container #354

merged 2 commits into from
Jan 9, 2024

Conversation

dirkmueller
Copy link
Member

No description provided.

mloviska
mloviska previously approved these changes Dec 21, 2023
View reviewed changes
dcermak
dcermak requested changes Dec 21, 2023
View reviewed changes
Copy link
Collaborator

@dcermak dcermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_build and test_all are broken

@dirkmueller dirkmueller marked this pull request as draft December 21, 2023 13:40
dcermak
dcermak reviewed Dec 21, 2023
View reviewed changes
bci_tester/data.py Outdated Show resolved Hide resolved
@dirkmueller dirkmueller marked this pull request as ready for review December 22, 2023 22:02
@dirkmueller dirkmueller requested a review from dcermak December 22, 2023 22:02
mgrossu
mgrossu approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@mgrossu mgrossu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ricardobranco777
ricardobranco777 approved these changes Jan 2, 2024
View reviewed changes
Copy link

@ricardobranco777 ricardobranco777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion. LGTM

tests/test_mariadb.py Show resolved Hide resolved
@dirkmueller dirkmueller marked this pull request as draft January 3, 2024 18:38
@dirkmueller
Copy link
Member Author

(need to work on docker failures)

@dirkmueller dirkmueller force-pushed the mariadb_testing branch 2 times, most recently from aff9e29 to 6cf1e1b Compare January 6, 2024 18:24
@dirkmueller dirkmueller marked this pull request as ready for review January 8, 2024 09:59
dcermak
dcermak reviewed Jan 8, 2024
View reviewed changes
tests/test_mariadb.py Outdated Show resolved Hide resolved
@dirkmueller dirkmueller requested a review from dcermak January 9, 2024 10:17
@dcermak dcermak merged commit 1c3cb53 into main Jan 9, 2024
141 of 142 checks passed
@dcermak dcermak deleted the mariadb_testing branch January 9, 2024 16:26
rcmadhankumar pushed a commit that referenced this pull request Aug 30, 2024
@dcermak
Merge pull request #354 from SUSE/mariadb_testing
c42600b 
Initial testing for the mariadb container
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcermak dcermak dcermak approved these changes

@mgrossu mgrossu mgrossu approved these changes

@ricardobranco777 ricardobranco777 ricardobranco777 approved these changes

@mloviska mloviska mloviska left review comments

@grisu48 grisu48 Awaiting requested review from grisu48

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dirkmueller @ricardobranco777 @mloviska @mgrossu @dcermak