-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace entities w/URLs #175
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two suggestions, rest looks good to me, thanks!
@@ -210,18 +210,6 @@ use &deng;! --> | |||
|
|||
<!-- URLS --> | |||
|
|||
<!ENTITY dsc "https://documentation.suse.com"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to change something in this file because it is maintained via doc-kit (see the comment in the file header). But it also does not harm, the changes will simply be overwritten by the next doc-kit run (just one more click for me to confirm the overwriting).
Co-authored-by: Tanja Roth <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @dmpop!
Description
Replace entities with hard-wired URLs
Are there any relevant issues/feature requests?
Which product versions do the changes apply to?
When opening a PR, check all versions of the documentation that your PR applies to.
main
, no backport necessary)PR reviewer only: Have all backports been applied?
The doc team member merging your PR will take care of backporting to older documents.
When opening a PR, do not set the following check box.