Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace entities w/URLs #175

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Replace entities w/URLs #175

wants to merge 2 commits into from

Conversation

dmpop
Copy link
Contributor

@dmpop dmpop commented Mar 27, 2024

Description

Replace entities with hard-wired URLs

Are there any relevant issues/feature requests?

  • bsc#...
  • jsc#...

Which product versions do the changes apply to?

When opening a PR, check all versions of the documentation that your PR applies to.

  • SLES-SAP 15
    • 15 next (current main, no backport necessary)
    • 15 SP5
    • 15 SP4
    • 15 SP3
    • 15 SP2
    • 15 SP1
  • SLES-SAP 12
    • 12 SP5
    • 12 SP4

PR reviewer only: Have all backports been applied?

The doc team member merging your PR will take care of backporting to older documents.
When opening a PR, do not set the following check box.

  • all necessary backports are done

@dmpop dmpop requested a review from taroth21 March 27, 2024 13:22
Copy link
Contributor

@taroth21 taroth21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two suggestions, rest looks good to me, thanks!

@@ -210,18 +210,6 @@ use &deng;! -->

<!-- URLS -->

<!ENTITY dsc "https://documentation.suse.com">
Copy link
Contributor

@taroth21 taroth21 Apr 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to change something in this file because it is maintained via doc-kit (see the comment in the file header). But it also does not harm, the changes will simply be overwritten by the next doc-kit run (just one more click for me to confirm the overwriting).

xml/product-entities.ent Outdated Show resolved Hide resolved
xml/product-entities.ent Outdated Show resolved Hide resolved
Copy link
Contributor

@taroth21 taroth21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @dmpop!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants