Skip to content

Commit

Permalink
Merge pull request #5208 from hallieswan/SWC-6555
Browse files Browse the repository at this point in the history
SWC-6555: skip test in webkit in CI to avoid using an even longer timeout in Sage runner
  • Loading branch information
hallieswan authored Oct 20, 2023
2 parents 22cc985 + 2586a80 commit 893fe6d
Showing 1 changed file with 11 additions and 9 deletions.
20 changes: 11 additions & 9 deletions e2e/files.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -146,15 +146,17 @@ test.describe('Files', () => {
testAuth(
'File sharing',
async ({ userPage, validatedUserPage, browserName }, testInfo) => {
if (browserName === 'webkit') {
test.info().annotations.push({
type: 'very slow',
description: `webkit in CI only. May be related to the InviteWidget.
Evaluate if timeout can be removed after addressing
https://sagebionetworks.jira.com/browse/SWC-6569.`,
})
test.setTimeout(testInfo.timeout * 5)
}
// Use test.fixme because test.fail doesn't mark test as expected to fail
// when there is a test timeout. Since test timeouts are expensive,
// Playwright recommends skipping the test entirely with test.fixme.
// See: https://github.com/microsoft/playwright/issues/16317
test.fixme(
browserName === 'webkit' && !!process.env.CI,
`Very slow in webkit in CI only (passes after 6min in macos-latest runner,
times out after 10min in Sage ubuntu-22.04-4core-16GBRAM-150GBSSD runner).
May be related to the InviteWidget. Evaluate if test passes after addressing
https://sagebionetworks.jira.com/browse/SWC-6569.`,
)

const userName = userConfigs['swc-e2e-user'].username
const validatedUserName = userConfigs['swc-e2e-user-validated'].username
Expand Down

0 comments on commit 893fe6d

Please sign in to comment.