Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWC-6577: after a new website version is detected, automatically relo… #5199

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

jay-hodgson
Copy link
Member

…ad the site after 30 minutes

@jay-hodgson jay-hodgson requested a review from nickgros October 11, 2023 17:12
Copy link
Contributor

@nickgros nickgros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 questions:

  1. Out of curiosity, what did loading the iframe accomplish before this change?
  2. Will this reload get blocked by an open editor (i.e. GlobalApplicationState.isEditing)?

@jay-hodgson
Copy link
Member Author

jay-hodgson commented Oct 11, 2023

  1. Out of curiosity, what did loading the iframe accomplish before this change?

Loading the new code in an iframe preloaded the new web app assets.

  1. Will this reload get blocked by an open editor (i.e. GlobalApplicationState.isEditing)?

Yes, I think it will! And if that editor has some UI driven event loop that calls remote services, then SWC-6577 could still occur. But this change should drastically reduce the space where this bug lives.

@jay-hodgson jay-hodgson merged commit 14b2fa1 into Sage-Bionetworks:develop Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants