SWC-6882 - Reapply migrate Bootstrap 3 Row/Column to MUI Grid #5506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickgros
changed the title
|
🎉 All dependencies have been resolved ! |
…882b This reverts commit 3181e4a.
…oot` always run in sequence.
|
E2E passing here: https://github.com/nickgros/SynapseWebClient/actions/runs/10775394099 |
nickgros
commented
Sep 9, 2024
Comment on lines
+187
to
200
| // Asynchronously schedule root operations in case the component is in the middle of an asynchronous render cycle | ||
| // See https://stackoverflow.com/questions/73459382 | ||
| Timer t = new Timer() { | ||
| @Override | ||
| public void run() { | ||
| componentToRender.createRoot(); | ||
| if (shouldDestroyRoot) { | ||
| destroyRoot(); | ||
| } | ||
|
|
||
| // Create a fresh ReactElement tree and render it | ||
| componentToRender.createRoot(); | ||
| componentToRender.root.render(componentToRender.createReactElement()); | ||
| } | ||
| }; |
There was a problem hiding this comment.
Combine the destroyRoot/createRoot into one sequential operation to handle race conditions where appended GWT widgets could not be updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #5505
Reapply "Merge pull request from nickgros/SWC-6882b"
This reverts commit 3181e4a.