SWC-7049 - Fix remounting/cleanup issue with React components #5509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… before the current render task finished. See facebook/react#25675
nickgros
commented
Aug 30, 2024
Comment on lines
+359
to
+362
| await userPage | ||
| .getByRole('link', { name: 'Files', exact: true }) | ||
| .first() | ||
| .click() |
There was a problem hiding this comment.
E2E test changes are from #5497, which also had one of the React component fixes in the same commit, so it ended up also being pulled in here.
jay-hodgson
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling #5497 and d8211e6 from #5508 into release-511 to fix SWC-7049