SWC-6663: build and publish SWC artifact from GH #5513
Conversation
xschildw
changed the title
| git push origin $new_branch | ||
| echo "pomversion=$new_tag" >> $GITHUB_ENV | ||
|
|
||
| - id: build_new_release_branch |
There was a problem hiding this comment.
The original idea was to just push in the step above and have the trigger do the build but the trigger does not get fired if the push is coming from an action (unless it's done with a PAT), so starting a build of the new branch here.
There was a problem hiding this comment.
The commit should already be tested, so this seems fine. When would we run this workflow?
| - id: build_new_release_branch | ||
| uses: ./.github/workflows/build | ||
| with: | ||
| mvn_goal: package |
There was a problem hiding this comment.
package first to test
|
|
||
| - uses: ./.github/workflows/build | ||
| with: | ||
| mvn_goal: package |
There was a problem hiding this comment.
package first to test
xschildw
changed the title
| tag_name="${release_number}.1" | ||
| git tag -a $tag_name -m stack-${release_number}-prod |
There was a problem hiding this comment.
I feel like I'm just missing some context:
- How do we build + tag patch versions today? Will this be compatible with that process (or is that an intended future change)?
- What's the purpose of these new
-prod/-stagingtags?
There was a problem hiding this comment.
Now I manually run a shell script that takes the repo, the current and next release number (e.g. 'create-branch ~/bin/create-branch.sh SynapseWebClient 512 513') to tag and create the branches each week. It clones the repo and does essentially the same steps as here (simpler since I give it the versions...). I figured it'd be nice to just click a button right in GH since I'm there re-checking that everything is merged anyway.
The '-prod' and 'staging' are just added to the comment on the git tag (to remind that .0 lives while that version is on staging and .1 while it's in prod).
To version the artifacts, we use 2 scripts (one for dev branch, one for release branches) that modify the version in all the pom.xml files, I would like to replace them by the optional 'mvn versions:set' step in build/actions.yml.
This PR should enable building SWC and publishing the artifact from Github Workflow