SWC-7044 - Handle error when fetching feature flag configuration #5587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attempt to recover on a BadRequestException by re-initializing the client
nickgros
commented
Nov 22, 2024
| "JSONObjectAdapterException occurred in default configuration", | ||
| e | ||
| ); | ||
| throw new RuntimeException(e); |
There was a problem hiding this comment.
If we can't serialize a constant string "{}", we have bigger problems
nickgros
commented
Nov 22, 2024
Comment on lines
118
to
125
| if (configurationToken == null) { | ||
| logger.log(Level.SEVERE, "returning default config"); | ||
| return new JSONObjectAdapterImpl(DEFAULT_CONFIG_VALUE); | ||
| logger.log( | ||
| Level.SEVERE, | ||
| "The configuration token is null, the last config value will be returned." + | ||
| " This usually means that the initial call to initialize the configuration session failed." | ||
| ); | ||
| return getLastConfigValueOrDefault(); | ||
| } |
There was a problem hiding this comment.
It seems like this error case will only happen when initialization failed, so I updated the log message to give context.
nickgros
commented
Nov 22, 2024
Comment on lines
+141
to
+149
| } catch (BadRequestException | InternalServerException e) { | ||
| // Invalid token or server error, re-initialize the session to try to recover. | ||
| logger.log( | ||
| Level.SEVERE, | ||
| "Failed to get latest configuration, returning last or default configuration and attempting to re-initialize the session.", | ||
| e | ||
| ); | ||
| initializeAppConfigClient(); | ||
| return getLastConfigValueOrDefault(); |
There was a problem hiding this comment.
In the logs, a BadRequestException was thrown with message "Token not valid". The tokens are one-time-use and my hypothesis is that we probably used a token more than once (maybe some network failure occurred and we didn't get the response containing a new token). Attempt to recover by re-initializing the session and getting a fresh token.
jay-hodgson
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attempt to recover on a BadRequestException by re-initializing the client