Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWC-7196 - Use correct GlobalApplicationState singleton instance #5591

Merged
merged 1 commit into from
Nov 27, 2024
Merged

SWC-7196 - Use correct GlobalApplicationState singleton instance #5591

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ...main/java/org/sagebionetworks/web/client/widget/entity/download/UploadDialogWidgetV2.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
import com.google.gwt.user.client.ui.Widget;
import com.google.inject.Inject;
import org.sagebionetworks.web.client.GlobalApplicationState;
import org.sagebionetworks.web.client.GlobalApplicationStateImpl;
import org.sagebionetworks.web.client.context.SynapseReactClientFullContextPropsProvider;
import org.sagebionetworks.web.client.events.EntityUpdatedEvent;
import org.sagebionetworks.web.client.jsinterop.EntityUploadHandle;
Expand All @@ -27,7 +26,7 @@ public class UploadDialogWidgetV2 extends Widget {

@Inject
public UploadDialogWidgetV2(
GlobalApplicationStateImpl globalApplicationState,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This erroneous injection registered the uploader's drag & drop handler on a new instance of GlobalApplicationStateImpl instead of the singleton.

GlobalApplicationState globalApplicationState,
EventBus eventBus,
SynapseReactClientFullContextPropsProvider contextProvider
) {
Expand Down