Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove restriction on base #12

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

tonicebrian
Copy link
Contributor

The restriction on base < 4.18 prevents compiling with GHC 9.6.6 and higher. I think it is safe to drop that restriction entirely.

Could you please bump this version to hackage?

The restriction on base < 4.18 prevents compiling with GHC 9.6.6 and higher. I think it is safe to drop that restriction entirely.
@SamuelSchlesinger SamuelSchlesinger merged commit af6ce7d into SamuelSchlesinger:master Dec 10, 2024
5 checks passed
@SamuelSchlesinger
Copy link
Owner

When I tried to upload this to hackage, I see:

[missing-bounds-important] The dependency 'build-depends: base' does not
specify an upper bound on the version number. Each major release of the 'base'
package changes the API in various ways and most packages will need some
changes to compile with it. The recommended practice is to specify an upper
bound on the version of the 'base' package. This ensures your package will
continue to build when a new major version of the 'base' package is released.
If you are not sure what upper bound to use then use the next major version.
For example if you have tested your package with 'base' version 4.5 and 4.6
then use 'build-depends: base >= 4.5 && < 4.7'.

@tonicebrian
Copy link
Contributor Author

Ups sorry, I didn't know that hackage doesn't allow the uncapped base. I'll create a new PR with latest base

@tonicebrian tonicebrian deleted the patch-1 branch December 10, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants