Don't crop header logo to thumbnail size #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -15,7 +15,7 @@ public function __construct() { | |||
|
|
|||
| public function getLogo() { | |||
| if ($this->logo) { | |||
| return $this->logo['sizes']['thumbnail']; | |||
| return $this->logo['sizes']['large']; | |||
There was a problem hiding this comment.
Will WordPress give us an upscaled logo if we ask for the large one? For example, if we upload a 120x80 or something, would it blow it up to something like 1280x800?
We could use $this->logo['url'] to get the original file upload.
Added #6 to introduce custom sizes, such that we can later do $this->logo['sizes']['logo']
| @@ -27,5 +27,8 @@ | |||
| require_once($filepath); | |||
| } | |||
|
|
|||
| // Custom image size for header logo | |||
| add_image_size( 'logo', 194, 88 ); | |||
There was a problem hiding this comment.
If we're gonna add this in now, we'll want to add this to lib/init.php and have it execute as part of the after_setup_theme hook. With the setup we have here, functions.php is just a loader.
I'll add some documentation to make this setup a bit more clear
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.