Fix 2 separate issues. #1076
Closed
Fix 2 separate issues. #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size_t is same as uint32_t for WIN32. Function alignedSize is defined twice. Fix build errors for WIN32 config
There is a resource dependency between compute and draw job from two different queues, explicit synchronization must be done to avoid potential problem. Also unset signal during the creation to align each compute to corresponding draw in every frame, starting from 1st frame. Space alignment
|
Created new pull to replace the old one, content revised and commits squashed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1st commit:
This project's default build config is x64. When building with 32-bit Windows config, there will be the following errors:
"Vulkan\base\VulkanTools.cpp(440): error C2084: function 'uint32_t vks::tools::alignedSize(uint32_t,uint32_t)' already has a body"
This change fixed it, however if there is no plan to support 32-bit Windows build, this change is not necessary.
2nd commit:
Fixed some render problems on certain platforms.