fix(OnyxFormElement): fix broken counter text when maxlength with counter is used #2534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b4322cb The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JoCa96
force-pushed
the
joca96/fix-max-length-counter-broken
branch
from
436cb41 to
b811ae2
Compare
larsrickert
requested changes
Jan 16, 2025
packages/sit-onyx/src/components/OnyxFormElement/OnyxFormElement.vue
Outdated
Show resolved
Hide resolved
larsrickert
requested changes
Jan 16, 2025
packages/sit-onyx/src/components/OnyxFormElement/OnyxFormElement.ct.tsx
Outdated
Show resolved
Hide resolved
…axlength with counter is used
…nt.vue Co-authored-by: Lars Rickert <[email protected]>
This is an auto-generated pull request. All Playwright screenshots have been updated. Co-authored-by: JoCa96 <[email protected]>
JoCa96
force-pushed
the
joca96/fix-max-length-counter-broken
branch
from
b4322cb to
771b47c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
defineSlotsto get rid of vue warning