Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1191 Initialization of ICU compartments after July 2024 #1192

Merged

Conversation

HenrZu
Copy link
Contributor

@HenrZu HenrZu commented Jan 16, 2025

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • The dataset for the ICU data is no longer maintained (ended in july 24)
  • Use the same way of initializing the severe and symptomatic infections for the icu then.

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

@HenrZu HenrZu changed the title 1191 Initialization of ICU after July 2024 1191 Initialization of ICU compartments after July 2024 Jan 16, 2025
@HenrZu HenrZu linked an issue Jan 16, 2025 that may be closed by this pull request
2 tasks
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.12%. Comparing base (adc7c49) to head (b30df0d).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1192      +/-   ##
==========================================
+ Coverage   96.97%   97.12%   +0.15%     
==========================================
  Files         148      148              
  Lines       13718    13777      +59     
==========================================
+ Hits        13303    13381      +78     
+ Misses        415      396      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HenrZu HenrZu requested a review from reneSchm January 20, 2025 08:00
cpp/models/ode_secirvvs/parameters_io.cpp Outdated Show resolved Hide resolved
cpp/models/ode_secir/parameters_io.cpp Show resolved Hide resolved
cpp/models/ode_secir/parameters_io.h Outdated Show resolved Hide resolved
cpp/models/ode_secir/parameters_io.h Outdated Show resolved Hide resolved
cpp/models/ode_secirts/parameters_io.h Outdated Show resolved Hide resolved
cpp/tests/test_odesecir.cpp Show resolved Hide resolved
cpp/memilio/io/epi_data.h Outdated Show resolved Hide resolved
@HenrZu HenrZu requested a review from reneSchm January 21, 2025 10:41
Copy link
Member

@reneSchm reneSchm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are better, please fix the hard-coded AgeGroups.

cpp/tests/test_odesecirts.cpp Outdated Show resolved Hide resolved
@HenrZu HenrZu merged commit 1df315d into main Jan 21, 2025
58 checks passed
@HenrZu HenrZu deleted the 1191-DIVI-Data-is-not-available-for-dates-later-than-July-2024 branch January 21, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DIVI Data is not available for dates later than July 2024.
2 participants