Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

up #1797

Merged
merged 1 commit into from
Jan 10, 2025
Merged

up #1797

merged 1 commit into from
Jan 10, 2025

Conversation

emrgnt-cmplxty
Copy link
Contributor

@emrgnt-cmplxty emrgnt-cmplxty commented Jan 10, 2025

Important

Add OAuth credentials to Docker Compose files and remove a debug print statement from users_router.py.

  • Configuration:
    • Add OAuth credentials (GOOGLE_CLIENT_ID, GOOGLE_CLIENT_SECRET, GOOGLE_REDIRECT_URI, GITHUB_CLIENT_ID, GITHUB_CLIENT_SECRET, GITHUB_REDIRECT_URI) to compose.full_with_replicas.yaml and compose.yaml.
  • Code Cleanup:
    • Remove debug print statement from google_callback in users_router.py.

This description was created by Ellipsis for 8192596. It will automatically update as commits are pushed.

@emrgnt-cmplxty emrgnt-cmplxty marked this pull request as ready for review January 10, 2025 01:43
@emrgnt-cmplxty emrgnt-cmplxty merged commit 33541cc into main Jan 10, 2025
3 checks passed
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 8192596 in 29 seconds

More details
  • Looked at 65 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. py/core/main/api/v3/users_router.py:1840
  • Draft comment:
    Remove the print statement used for debugging.
            ```
  • Reason this comment was not posted:
    Comment looked like it was already resolved.

Workflow ID: wflow_E8ViL56MVcRX8t1B


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant