Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Never from typing to typing_extensions #1808

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

NolanTrem
Copy link
Collaborator

@NolanTrem NolanTrem commented Jan 11, 2025

Important

Move Never import from typing to typing_extensions in command_group.py.

  • Imports:
    • Move Never from typing to typing_extensions in command_group.py.

This description was created by Ellipsis for ee432dd. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to ee432dd in 6 seconds

More details
  • Looked at 21 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. py/cli/command_group.py:7
  • Draft comment:
    Remove the unused import of Never from typing to avoid confusion and maintain clarity.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The import statement for Never from typing_extensions is correctly added, but the original import from typing should be removed. This is a minor issue but should be addressed for clarity and to avoid confusion.

Workflow ID: wflow_x5aDWxv7wxgZKI0M


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@NolanTrem NolanTrem merged commit 9ec211f into main Jan 11, 2025
9 of 14 checks passed
@NolanTrem NolanTrem deleted the Nolan/NeverNeverFromTyping branch January 11, 2025 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant