-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add agent content tool #1854
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 4f0b50c in 4 minutes and 44 seconds
More details
- Looked at
12362
lines of code in158
files - Skipped
0
files when reviewing. - Skipped posting
3
drafted comments based on config settings.
1. py/core/providers/database/documents.py:84
- Draft comment:
The logic for checking and adding thetotal_tokens
column is overly complex. Consider simplifying the check for existing columns and streamline the logic for adding the column if it doesn't exist. - Reason this comment was not posted:
Confidence changes required:50%
The code is checking for the presence of a column in a database table, but the logic is overly complex and could be simplified. The check for existing columns and the subsequent logic could be streamlined.
2. py/core/providers/database/documents.py:92
- Draft comment:
Consider providing a more user-friendly error message when the 'total_tokens' column is missing but documents are present. This will help users understand the next steps more clearly. - Reason this comment was not posted:
Confidence changes required:50%
The code is checking for the presence of a 'total_tokens' column in the 'documents' table. If the column is missing, it checks if the table already has data. If data is present, it raises an error asking the user to run a migration. This is a good practice to ensure schema consistency, but the error message could be more user-friendly.
3. py/core/providers/database/documents.py:95
- Draft comment:
Consider providing a more user-friendly error message when the 'total_tokens' column is missing but documents exist. This will help users understand the next steps more clearly. - Reason this comment was not posted:
Confidence changes required:50%
The code is checking for the presence of the 'total_tokens' column in the documents table. If the column is missing, it checks if there are existing documents. If there are, it raises an error asking the user to run a migration. This is a good practice to ensure data integrity, but the error message could be more user-friendly.
Workflow ID: wflow_3k5aicvPmGjKCkp7
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
This pull request adds agent content tools, refactors retrieval and RAG agents, updates configurations, and enhances database models, while also cleaning up deprecated code and updating tests.
maxToolContextLength
andtools
parameters toRetrievalClient
inretrieval.ts
.RetrievalClient
to handle new parameters in requests.tool_names
withtools
in multiple TOML configuration files.r2r.toml
to includecontent
intools
.RAGAgentMixin
for adding local search, web search, and content tools.R2RRAGAgent
andR2RStreamingRAGAgent
to useRAGAgentMixin
.rag.py
.total_tokens
column todocuments
table indocuments.py
.total_tokens
.test_chunks.py
andtest_limits.py
to reflect new functionality.test_collection_id_filter.py
.This description was created by for 4f0b50c. It will automatically update as commits are pushed.