Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rtmp test workaround #263

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

lennartkloock
Copy link
Member

@lennartkloock lennartkloock commented Jan 21, 2025

  • Introduces a workaround for the failing rtmp test

@TroyKomodo
Copy link
Member

what if we just add a delay?

Copy link

cloudflare-workers-and-pages bot commented Jan 21, 2025

Deploying scuffle-docrs with  Cloudflare Pages  Cloudflare Pages

Latest commit: e54c4a0
Status: ✅  Deploy successful!
Preview URL: https://b90d2331.scuffle-docrs.pages.dev
Branch Preview URL: https://pr-263.scuffle-docrs.pages.dev

View logs

Copy link

codecov bot commented Jan 21, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
305 1 304 0
View the top 1 failed tests by shortest run time
rtmp tests::rtmp::test_basic_rtmp_clean
Stack Traces | 1.18s run time
thread 'tests::rtmp::test_basic_rtmp_clean' panicked at .../src/tests/rtmp.rs:101:5:
assertion failed: ffmpeg.try_wait().expect("failed to wait for ffmpeg").is_none()
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@lennartkloock
Copy link
Member Author

what if we just add a delay?

Why do we even check if ffmpeg is done?

@TroyKomodo
Copy link
Member

Because ffmpeg should be done at that point i think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants