Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WS-488] [WS-954] feature/comment #153

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Conversation

TrevorBurgoyne
Copy link
Member

@TrevorBurgoyne TrevorBurgoyne commented Jun 4, 2024

feature/comment

WS-488
WS-954

Description

  • Fix bug where typing in text boxes would sometimes trigger keybinds.
    • This fix included a refactor of some keypress events by combining them into a single event listener.
  • Deprecated the default_keybinds argument in the configuration object. Each of the keybinds previously set by default_keybinds can now be set individually. See api_spec.md for details.
  • Deprecated the default_annotation_size argument in the configuration object. Use the initial_line_size argument instead. See api_spec.md for details.
  • Removed cookie previously used to track subtask line size. New jobs will always default to the initial_line_size argument if provided.
  • Rework vanish mode to truly vanish annotations rather than just drawing them really really small. Also vanish all dialogs while vanished.

PR Checklist

  • Merged latest main
  • Version number in package.json has been bumped since last release
  • Version numbers match between package package.json and src/version.js
  • Ran npm install and npm run build AFTER bumping the version number
  • Updated documentation if necessary (currently just in api_spec.md)
  • Added changes to changelog.md

Breaking API Changes

  • Deprecated the default_keybinds argument in the configuration object. Each of the keybinds previously set by default_keybinds can now be set individually. See api_spec.md for details.
  • Deprecated the default_annotation_size argument in the configuration object. Use the initial_line_size argument instead. See api_spec.md for details.
  • Removed cookie previously used to track subtask line size. Now the subtask line size is stored in local storage, and the initial_line_size argument takes precedence over the stored value.

…tener; refactor ResizeToolboxItem; deprecate unused/redundant config args
@TrevorBurgoyne TrevorBurgoyne added bug Something isn't working enhancement New feature or request refactor The code should be better labels Jun 4, 2024
@TrevorBurgoyne TrevorBurgoyne changed the title [WS-488] feature/comment [WS-488] [WS-954] feature/comment Jun 5, 2024
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major refactor here. Moved some event listeners to index.js in order to catch when we should ignore keypress events (ie when typing in a text box).

Also reworked the resize toolbox item to (a) erase the canvas when vanishing rather than just shrinking the annotations, and (b) be more readable

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also removed the cookie that stored subtask size, since imo the configured initial_line_size should take precedence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request refactor The code should be better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant