engineering-update-hardsuit #2458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Changes: Sprites
|
RSI Diff Bot; head commit bd239da merging into 24b4f07 Resources/Textures/SS220/Clothing/Head/Hardsuits/atmospherics.rsi
Resources/Textures/SS220/Clothing/Head/Hardsuits/engineering-white.rsi
Resources/Textures/SS220/Clothing/Head/Hardsuits/engineering.rsi
Resources/Textures/SS220/Clothing/OuterClothing/Hardsuits/atmospherics.rsi
Resources/Textures/SS220/Clothing/OuterClothing/Hardsuits/engineering-white.rsi
Resources/Textures/SS220/Clothing/OuterClothing/Hardsuits/engineering.rsi
|
stalengd
reviewed
Jan 7, 2025
Comment on lines
+49
to
+56
| # - type: HandheldLight | ||
| # addPrefix: false | ||
| # - type: ToggleableLightVisuals | ||
| # spriteLayer: light | ||
| # clothingVisuals: | ||
| # head: | ||
| # - state: equipped-head-light | ||
| # shader: unshaded |
There was a problem hiding this comment.
Я так понимаю фонарик у него всё ещё работает, просто на спрайте не отображается или как?
There was a problem hiding this comment.
Спрайт фонарики накладывается, но теперь это одно png, а не две разных как было раньше. Теперь нет шейдера unshaded.
Подробнее, почему это надо убрать, описано в ишуе 2278 и 2286,
Если кратко, при накладывании слоёв, спрайты корректно отображаются только на расе человека
stalengd
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание PR
Окрошка умница
Медиа
Проверки
Изменения
🆑 Okroshka