Autoinjectors220 #881
Merged
Autoinjectors220 #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DexlerXD ревью мальчика |
Kit0vras
suggested changes
Apr 5, 2024
| name: Автоинжектор | ||
| parent: BaseItem | ||
| description: уээээ | ||
| id: BaseAutoinjectorss220 |
There was a problem hiding this comment.
у тебя есть базовый инъектор, задай максимум компонентов у него, (к примеру, вместимость поставь на 10), сделай его абстрактным и наследуй в обычном инъекторе ниже этот инъектор (что и делается)
За счёт наследования ты сможешь не повторять кучу строк
если понадобится бОльший инжектор - вот конкретно на нём можно будет дописать вместимость на 15
DexlerXD
suggested changes
Apr 5, 2024
| @@ -16,7 +17,6 @@ | |||
| using Robust.Shared.GameStates; | |||
| using System.Diagnostics.CodeAnalysis; | |||
| using System.Linq; | |||
|
|
|||
| SubscribeLocalEvent<AutoinjectorComponent, AfterHypoEvent>(OnCheck); | ||
| } | ||
|
|
||
| private void OnCheck(EntityUid uid, AutoinjectorComponent component, AfterHypoEvent args) |
There was a problem hiding this comment.
лучшим неймингом будет OnAfterHypo, т. к. такое название отображает к чему подсосан метод
github-actions
bot
added
the
Changes: Sprites
|
@Gnomeev с чем тебе помочь, чтобы закончить? |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
Changes: Localization
|
@Gnomeev конфликты бро |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание PR
Добавлены автоинжекторы, по таску от сурани
Добавлен крафт автоинжекторов через медфаб
Добавлен
AfterHypoEvent, вызывающийся после использования гипоспрея и ему подобныхМедиа
Проверки
Изменения
🆑 Gnomeev