fix(oauth): parseCode return empty string, instead of value (#279)

SevereCloud · Mar 7, 2024 · 239a35a · 239a35a
1 parent c444552
commit 239a35a
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/api/oauth/group_test.go b/api/oauth/group_test.go
@@ -139,7 +139,7 @@ func TestAuthCodeFlowGroup_Token(t *testing.T) {
 	}
 
 	// f("https://oauth.vk.com/blank.html#;", "invalid semicolon separator in query")
-	f("https://oauth.vk.com/blank.html#error=invalid_request&error_description=Invalid+display+parameter", "oauth: Invalid display parameter")
+	f("https://oauth.vk.com/blank.html?error=invalid_request&error_description=Invalid+display+parameter", "oauth: Invalid display parameter")
 }
 
 func TestImplicitFlowGroup(t *testing.T) {

diff --git a/api/oauth/oauth.go b/api/oauth/oauth.go
@@ -80,7 +80,7 @@ const (
 )
 
 func parseCode(u *url.URL) (string, error) {
-	v, err := url.ParseQuery(u.Fragment)
+	v, err := url.ParseQuery(u.RawQuery)
 
 	if errType := v.Get("error"); errType != "" {
 		err = &Error{

diff --git a/api/oauth/user_test.go b/api/oauth/user_test.go
@@ -127,7 +127,7 @@ func TestAuthCodeFlowUser_Token(t *testing.T) {
 	}
 
 	// f("https://oauth.vk.com/blank.html#;", "invalid semicolon separator in query")
-	f("https://oauth.vk.com/blank.html#error=invalid_request&error_description=Invalid+display+parameter", "oauth: Invalid display parameter")
+	f("https://oauth.vk.com/blank.html?error=invalid_request&error_description=Invalid+display+parameter", "oauth: Invalid display parameter")
 }
 
 func TestImplicitFlowUser(t *testing.T) {