Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update new mode to post-sensor mode #431

Merged
merged 4 commits into from
Jan 2, 2025
Merged

Conversation

Known4225
Copy link
Contributor

This PR closes #425

This changes a single line in user_config.h to refer to the timing manager's "new mode" to "post-sensor mode" instead.

@Known4225 Known4225 requested a review from elsevers as a code owner December 24, 2024 18:33
@elsevers elsevers linked an issue Dec 26, 2024 that may be closed by this pull request
Copy link
Contributor

@elsevers elsevers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Known4225.

Can you update the comment intiming_manager.c where USER_CONFIG_ISR_SOURCE is used as well?

/*
* Specify the interrupt source of the scheduler ISR:
*
* Mode 0 uses the timing manager's 'trigger' signal, i.e. the control
* frequency is based on the PWM carrier frequency and the user-specified PWM sub-ratio.
*
* Mode 1 uses the timing manager's 'all_done' signal, calling the scheduler
* when all the sensors are done with acquisition. When no sensors are enabled,
* the scheduler is called as in mode 0 (based on the trigger). This mode
* supports reporting of the timing for each sensor
*/
void timing_manager_set_scheduler_source(void)

Copy link
Contributor

@elsevers elsevers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Looks good.

@Known4225 Known4225 merged commit 691f32e into develop Jan 2, 2025
1 check passed
@Known4225 Known4225 deleted the known4225/update-user-config branch January 2, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update user_config.h to use "Post-Sensor mode" instead of "New mode"
2 participants