Video Sprite Fixes & Improvements #16138
Open
+51
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LarryFrosty
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
playfunction toVideoSpritefor easier handlingautoPauseargument toVideoSprite's constructor (used in PlayState to set to false to allow substate pausing correctly and whatnot)VideoSpritenow removes itself from the state/substate its added in instead of only PlayStatevideoCutscenewill now pause when a substate is opened and resumes when closed, the autoPause from the hxvlc class will be disabled for manual handling as said abovevideoCutscenewill now be removed from PlayState when the player leaves or diesvideoCutscenewill now follow the playback ratestartVideostartVideo's arguments to Lua'sstartVideostartVideowill now add to GameOverSubstate if the player is deaddestroy