-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve button component UI (use colors from design tokens) #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulkeswani101
previously approved these changes
Oct 14, 2024
vikrantgupta25
previously approved these changes
Oct 21, 2024
@ahmadshaheer the fonts are not applied in the preview. We need to use font Inter family |
Done, @sharpshooter90 👍 |
YounixM
previously approved these changes
Oct 28, 2024
ahmadshaheer
force-pushed
the
chore/improve-button-UI
branch
from
November 11, 2024 02:54
7261c67
to
6fe230e
Compare
YounixM
approved these changes
Nov 11, 2024
sharpshooter90
approved these changes
Nov 12, 2024
SagarRajput-7
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After: