fix: simple cors requests enabled by default

Fixes #1640.
SignalK · Oct 9, 2023 · 53a12f0 · 53a12f0
1 parent c9dc28a
commit 53a12f0
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/src/cors.ts b/src/cors.ts
@@ -9,15 +9,20 @@ export function setupCors(
 ) {
   const corsDebug = createDebug('signalk-server:cors')
 
+  const corsOptions: CorsOptions = {
+    credentials: true,
+  }
   const corsOrigins = allowedCorsOrigins
     ? allowedCorsOrigins
         .split(',')
         .map((s: string) => s.trim().replace(/\/*$/, ''))
     : []
   corsDebug(`corsOrigins:${corsOrigins.toString()}`)
-  const corsOptions: CorsOptions = {
-    credentials: true,
-    origin: corsOrigins
+  // set origin only if corsOrigins are set so that
+  // we get the default cors module functionality
+  // for simple requests by default
+  if (corsOrigins.length) {
+    corsOptions.origin = corsOrigins
   }
 
   app.use(cors(corsOptions))