fix: use selfsigned instead of devcert for certificate generation #1650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Devcert replaced with Selfsigned package
KEGustafsson
changed the title
|
@cmotelet how does this look to you? Will this work on windows? |
tkurki
changed the title
tkurki
changed the title
|
I tested selfsigned image on Windows 10 with Docker Desktop. Docker-compose file applied from Cmd and WSL2. SK container came up fine. |
tkurki
reviewed
Oct 29, 2023
@tkurki , Sorry I missed this discussion ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1649 seen with Devcert self-signed certificate generation tool. Devcert require sudo for certain operations and that is not available from docker.