My fix #6
Merged
My fix #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The license of phpSysInfo must have been GPLv2. See http://phpsysinfo.svn.sourceforge.net/viewvc/phpsysinfo/trunk/COPYING?revision=545&view=markup and config.php included in PHPspeed says also GPLv2.
PHPspeed is now GPL licensed!! PHPspeed is now GPL licensed!! See http://www.phpspeed.com/phpspeed-forums-f1/phpspeed-is-now-gpl-licensed-t18.html And phpSysInfo is GPL licensed, so PHPspeed must be licensed by GPL.
|
Many thanks for your effort in this project. What I dislike a bit is that we're changing things in the phpSysInfo package ... We should rather update it. |
SimonSimCity
pushed a commit
that referenced
this pull request
Mar 9, 2012
* Fixed uninitialized variables in phpSysInfo package * Removed @-operator used for MySQL-functions * If mysql is not reachable the script will strictly die * Updated licenses to proper GNU-license (unmodified) * Fixed wrong variable names in mysql-file when checking the username and password * Partially removed transactions as it was not fully implemented * Updated error-handling while figuring out if package is installed
|
I opened #7 for updating the phpSysInfo library. If you want, you can take it :) |
|
You're right. it's better to update phpSysInfo. But I'm sorry, my benchmarking to my servers at this time has almost finished. I don't know when I'll benchmark next time. Thank you for your merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your updating PHPspeed.
I checked the license and updated the license files, to which I believe the correct license.
In my conclusion, PHPspeed is licenced under GPL2.
And removed some PHP notices and at marks.