Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File API V2: waza_p asset #532

Open
wants to merge 21 commits into
base: protocol-v2
Choose a base branch
from

Conversation

AnonymousRandomPerson
Copy link

@AnonymousRandomPerson AnonymousRandomPerson commented Aug 3, 2024

Based off #511, but rebased off master because the original branch has conflicts.

This PR includes:

  • Initializing an asset project by exporting files from the ROM.
  • Importing asset project files to the ROM.
  • Change detection using hashes on ROM/asset project files.
  • File config (with glob support) to map files to file types and indicate which files are included in the asset project.
  • Two-way conversion between waza_p.bin and two JSON files for moves and learnsets.
  • CLI for export/import + two-way sync.

Most of the stubs have been filled in, aside from:

  • Custom Skypatches
  • Symbol/Patch info assets

@theCapypara
Copy link
Member

theCapypara commented Aug 3, 2024

ℹ️ This continues off #526 which has been closed by accident

Copy link

github-actions bot commented Aug 3, 2024

Test Results

     6 files  ±0       6 suites  ±0   4m 51s ⏱️ +2s
 9 050 tests ±0   9 046 ✅  - 4      0 💤 ±0  4 ❌ +4 
18 096 runs  ±0  14 332 ✅  - 4  3 760 💤 ±0  4 ❌ +4 

For more details on these failures, see this check.

Results for commit 6f87b07. ± Comparison against base commit 812d7f0.

@AnonymousRandomPerson AnonymousRandomPerson marked this pull request as ready for review September 6, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants