-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File API V2: waza_p asset #532
Open
AnonymousRandomPerson
wants to merge
21
commits into
SkyTemple:protocol-v2
Choose a base branch
from
AnonymousRandomPerson:protocol-v2
base: protocol-v2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
File API V2: waza_p asset #532
AnonymousRandomPerson
wants to merge
21
commits into
SkyTemple:protocol-v2
from
AnonymousRandomPerson:protocol-v2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ℹ️ This continues off #526 which has been closed by accident |
theCapypara
force-pushed
the
protocol-v2
branch
from
August 3, 2024 20:49
e8315f7
to
6f87b07
Compare
Test Results 6 files ±0 6 suites ±0 4m 51s ⏱️ +2s For more details on these failures, see this check. Results for commit 6f87b07. ± Comparison against base commit 812d7f0. |
AnonymousRandomPerson
force-pushed
the
protocol-v2
branch
2 times, most recently
from
August 16, 2024 01:11
6c6b4c4
to
74ca388
Compare
AnonymousRandomPerson
force-pushed
the
protocol-v2
branch
from
August 31, 2024 03:46
148a5a0
to
d5e7091
Compare
AnonymousRandomPerson
force-pushed
the
protocol-v2
branch
from
September 6, 2024 04:19
faee769
to
b8a2152
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off #511, but rebased off master because the original branch has conflicts.
This PR includes:
waza_p.bin
and two JSON files for moves and learnsets.Most of the stubs have been filled in, aside from: