Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bitwarden to Dockerfile #1562

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add Bitwarden to Dockerfile #1562

wants to merge 2 commits into from

Conversation

suchintan
Copy link
Contributor

@suchintan suchintan commented Jan 15, 2025

Important

Add Bitwarden CLI installation to Dockerfile with Node.js setup using nvm.

  • Dockerfile Changes:
    • Add Node.js environment setup using nvm with NODE_VERSION set to v20.12.2.
    • Install Bitwarden CLI globally using npm with version 2024.9.0.
    • Verify Bitwarden CLI installation by running bw --version.

This description was created by Ellipsis for 5428242. It will automatically update as commits are pushed.

@suchintan suchintan requested a review from LawyZheng January 15, 2025 15:26
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 5428242 in 43 seconds

More details
  • Looked at 30 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. Dockerfile:16
  • Draft comment:
    Consider adding apt-get update before apt-get install to ensure the package list is up-to-date. Also, add rm -rf /var/lib/apt/lists/* after apt-get clean to reduce image size.
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_3ykUsrfLK0XLQBaT


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cUrl is not installed, i'd recommand to add this before install nvm

install curl

RUN apt-get update && apt-get install -y curl && apt-get clean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants