[harvest] common identfier behavior

SlovakNationalGallery · Nov 2, 2023 · 49e801b · 49e801b
1 parent c16407a
commit 49e801b
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 11 deletions.
diff --git a/app/Harvest/Harvesters/GmuhkItemHarvester.php b/app/Harvest/Harvesters/GmuhkItemHarvester.php
@@ -2,7 +2,6 @@
 
 namespace App\Harvest\Harvesters;
 
-use App\Harvest\Harvesters\AbstractHarvester;
 use App\Harvest\Importers\GmuhkItemImporter;
 use App\Harvest\Repositories\GmuhkItemRepository;
 

diff --git a/app/Harvest/Importers/AbstractImporter.php b/app/Harvest/Importers/AbstractImporter.php
@@ -35,13 +35,16 @@ public function __construct(AbstractMapper $mapper) {
      * @param array $row
      * @return mixed
      */
-    abstract function getModelId(array $row);
+    abstract public function getModelId(array $row);
 
     /**
      * @param array $row
      * @return string
      */
-    abstract function getIdentifier(array $row);
+    public function getIdentifier(array $row)
+    {
+        return $this->getModelId($row);
+    }
 
     /**
      * @param array $row

diff --git a/app/Harvest/Importers/AuthorityImporter.php b/app/Harvest/Importers/AuthorityImporter.php
@@ -51,10 +51,6 @@ public function getModelId(array $row) {
         return $this->mapper->mapId($row);
     }
 
-    public function getIdentifier(array $row) {
-        return $this->getModelId($row);
-    }
-
     protected function upsertModel(Model $model, array $row) {
         if ($model->exists) {
             unset($row['biography']);

diff --git a/app/Harvest/Importers/ItemImporter.php b/app/Harvest/Importers/ItemImporter.php
@@ -42,10 +42,6 @@ public function getModelId(array $row) {
         return $this->mapper->mapId($row);
     }
 
-    public function getIdentifier(array $row) {
-        return $this->getModelId($row);
-    }
-
     protected function processHasMany(Model $model, $field, array $relatedRows, $allowDelete = true) {
         $allowDelete &= !in_array($field, ['images']);
         parent::processHasMany($model, $field, $relatedRows, $allowDelete);