Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed redundant commas between author roles #921

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Fixed redundant commas between author roles #921

merged 2 commits into from
Nov 3, 2023

Conversation

eronisko
Copy link
Contributor

@eronisko eronisko commented Nov 3, 2023 •
edited
Loading

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have updated the CHANGELOG
  • I have requested at least 1 reviewer for this PR
  • I have made corresponding changes to the documentation

@eronisko
Fixed redundant commas and missing CS translations for authority roles
3297483 
By implementing a workaround `formattedRoles` method
@eronisko
Much simpler work-around
c188fa6 
which does not confuse "creator" and authority roles
@eronisko eronisko force-pushed the WEBUMENIA-2033-redundant-commas-separating-authority-roles-with-m branch from 21911a1 to c188fa6 Compare November 3, 2023 09:45
@eronisko eronisko changed the title Fixed redundant commas and missing CS translations for authority roles Fixed redundant commas between author roles Nov 3, 2023
@eronisko eronisko merged commit 78d6bd8 into develop Nov 3, 2023
1 check passed
@eronisko eronisko deleted the WEBUMENIA-2033-redundant-commas-separating-authority-roles-with-m branch November 3, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rastislav-chynoransky rastislav-chynoransky rastislav-chynoransky approved these changes

@igor-kamil igor-kamil Awaiting requested review from igor-kamil

@FrantisekMichalSebestyen FrantisekMichalSebestyen Awaiting requested review from FrantisekMichalSebestyen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eronisko @rastislav-chynoransky