[import] mg exhibiton, box, location #935
Conversation
| ]); | ||
|
|
||
| $item = Item::find('CZE:MG.rada_s_123-lomeni_s'); | ||
| $this->assertEquals('BOX F04', $item->box); |
There was a problem hiding this comment.
Why not F04 (instead of BOX F04)?
There was a problem hiding this comment.
That's how it should get displayed in artwork details on the FE side.
https://sbirky.moravska-galerie.cz/dielo/CZE:MG.U_14802
There was a problem hiding this comment.
But is there a box not called BOX xx? (If not, the BOX part probably belongs to the presentation layer)
There was a problem hiding this comment.
Yes, in case of Design 2000+ exhibition the box field doesn’t contain BOX word.
| { | ||
| Schema::table('items', function (Blueprint $table) { | ||
| $table->string('exhibition')->nullable(); | ||
| $table->string('box')->nullable(); |
There was a problem hiding this comment.
The box part feels specific to MG. Maybe exhibition_placement? Or even combining exhibition and box into a single JSON column exhibition, e.g.:
{
"name": "BLACK DEPO",
"placement": "BOX 04",
}There was a problem hiding this comment.
You wouldn't be able to get aggregations for those fields if the data would be nested in json.
| Schema::table('items', function (Blueprint $table) { | ||
| $table->string('exhibition')->nullable(); | ||
| $table->string('box')->nullable(); | ||
| $table->string('location')->nullable(); |
There was a problem hiding this comment.
What kind of location is this? Could we use a more specific name? (In my mind, a location could be an address, country, current exhibition, GPS location,...)
There was a problem hiding this comment.
It's an identifier in the format of e.g. UPM/203/POSTMODERNA (specific to MG)
rastislav-chynoransky
force-pushed
the
MG-16
branch
from
7896395 to
58a9019
Compare
https://jira.sng.sk/browse/MG-16