Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BottomModal variant of the newsletter signup form #936

Merged
merged 3 commits into from
Dec 15, 2023

Conversation

eronisko
Copy link
Contributor

by disabling its tracking callbacks. These no longer seem compatible (with Vue3) and will be re-enabled as part of WEBUMENIA-2042, where we move away from Livewire

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have updated the CHANGELOG
  • I have requested at least 1 reviewer for this PR
  • I have made corresponding changes to the documentation

to make UserInteractionContxt vue3-compatible
As these are incompatible. This will be resolved as part of WEBUMENIA-2042
@eronisko eronisko merged commit f7939f7 into develop Dec 15, 2023
1 check passed
@eronisko eronisko deleted the WEBUMENIA-2039 branch December 15, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants