Fix a leak in DiskArbitrationEventPublisher::getProperty (osquery#8463)

Smjert · Nov 7, 2024 · 5ff3092 · 5ff3092
1 parent b8fbdbb
commit 5ff3092
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/osquery/events/darwin/diskarbitration.cpp b/osquery/events/darwin/diskarbitration.cpp
@@ -261,9 +261,11 @@ std::string DiskArbitrationEventPublisher::getProperty(
   } else if (CFGetTypeID(value) == CFBooleanGetTypeID()) {
     return (CFBooleanGetValue((CFBooleanRef)value)) ? "1" : "0";
   } else if (CFGetTypeID(value) == CFUUIDGetTypeID()) {
-    return stringFromCFString(
-        CFUUIDCreateString(kCFAllocatorDefault, (CFUUIDRef)value));
+    auto cf_string = CFUUIDCreateString(kCFAllocatorDefault, (CFUUIDRef)value);
+    auto string = stringFromCFString(cf_string);
+    CFRelease(cf_string);
+    return string;
   }
   return "";
 }
-}
+} // namespace osquery