Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResetPassword component styled using tailwind css #55

Open
wants to merge 5 commits into
base: pre-dev
Choose a base branch
from

Conversation

byronkenoly
Copy link

Description

Two new files in src folder: ForgotPassword.tsx, spaceYaTechLogo.svg

  • Created ForgotPassword component which is in the file ForgotPassword.tsx
  • SpaceYaTech logo added - exported from a figma file

Modified three files: public/index.html, src/index.tsx, tailwind.config.js

  • Copied and embedded Poppins font(specified in figma file) from google fonts in head tag of index.html
  • Imported ForgotPassword component in index.tsx file to render it in the browser (for testing purposes)
  • Added custom styles to theme section of tailwind.config.js

No additional dependencies used for these additions and modifications

Fixes #50 (issue)

Pending Issue

Eye icon in the password input field not yet added

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
    Rendered the component in a web browser. Everything looks OK.

Test Configuration: N/A

  • Firmware version: N/A
  • Hardware: N/A
  • Toolchain: N/A
  • SDK: N/A

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@byronkenoly byronkenoly linked an issue Dec 2, 2022 that may be closed by this pull request
src/index.tsx Outdated
import reportWebVitals from "./reportWebVitals";

const root = ReactDOM.createRoot(document.getElementById("root")!);
root.render(
<React.StrictMode>
<App />
{<ForgotPassword />}
{/*<App />*/}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this being commented out?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this being commented out?

Just to test how ForgotPassword component renders in the browser as currently we have no routes set up. Changes made in this src/index.tsx file can be done away with.

@byronkenoly byronkenoly requested a review from nyandika December 2, 2022 12:55
Copy link
Contributor

@nyandika nyandika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wuld recommend renaming the component to ResetPassword as that is what it is doing as opposed to forget password which would have an email/username input box to send the reset password link to

@byronkenoly
Copy link
Author

I wuld recommend renaming the component to ResetPassword as that is what it is doing as opposed to forget password which would have an email/username input box to send the reset password link to

Yes I agree, it sounds more intuitive. Is @jumalaw98 supposed to approve this first since he was the one who raised the issue and named it forgot password component?

@byronkenoly byronkenoly requested a review from nyandika December 4, 2022 07:47
@jumalaw98
Copy link
Contributor

I wuld recommend renaming the component to ResetPassword as that is what it is doing as opposed to forget password which would have an email/username input box to send the reset password link to

Yes I agree, it sounds more intuitive. Is @jumalaw98 supposed to approve this first since he was the one who raised the issue and named it forgot password component?

@byronkenoly thats noted, then can you change it on your updated files?

@jumalaw98 jumalaw98 changed the title Forgot password component styled using tailwind css ResetPassword component styled using tailwind css Dec 5, 2022
Copy link
Contributor

@daveclinton daveclinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a commit message for every files changed or added.

colors: {
secondaryGreen: '#03A47E',
primaryWhite: '#EBFBF7',
darkText: '##13131A'
darkText: '##13131A',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hex code doesn't look correct

@byronkenoly
Copy link
Author

I wuld recommend renaming the component to ResetPassword as that is what it is doing as opposed to forget password which would have an email/username input box to send the reset password link to

Yes I agree, it sounds more intuitive. Is @jumalaw98 supposed to approve this first since he was the one who raised the issue and named it forgot password component?

@byronkenoly thats noted, then can you change it on your updated files?

I have made the required changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Frontend]- Create forgot password-002 component
4 participants