-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ResetPassword component styled using tailwind css #55
base: pre-dev
Are you sure you want to change the base?
Conversation
src/index.tsx
Outdated
import reportWebVitals from "./reportWebVitals"; | ||
|
||
const root = ReactDOM.createRoot(document.getElementById("root")!); | ||
root.render( | ||
<React.StrictMode> | ||
<App /> | ||
{<ForgotPassword />} | ||
{/*<App />*/} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this being commented out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this being commented out?
Just to test how ForgotPassword component renders in the browser as currently we have no routes set up. Changes made in this src/index.tsx
file can be done away with.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wuld recommend renaming the component to ResetPassword as that is what it is doing as opposed to forget password which would have an email/username input box to send the reset password link to
Yes I agree, it sounds more intuitive. Is @jumalaw98 supposed to approve this first since he was the one who raised the issue and named it forgot password component? |
@byronkenoly thats noted, then can you change it on your updated files? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a commit message for every files changed or added.
tailwind.config.js
Outdated
colors: { | ||
secondaryGreen: '#03A47E', | ||
primaryWhite: '#EBFBF7', | ||
darkText: '##13131A' | ||
darkText: '##13131A', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This hex code doesn't look correct
I have made the required changes |
Description
Two new files in src folder:
ForgotPassword.tsx
,spaceYaTechLogo.svg
Modified three files:
public/index.html
,src/index.tsx
,tailwind.config.js
index.html
index.tsx
file to render it in the browser (for testing purposes)theme
section oftailwind.config.js
No additional dependencies used for these additions and modifications
Fixes #50 (issue)
Pending Issue
Eye icon in the password input field not yet added
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Rendered the component in a web browser. Everything looks OK.
Test Configuration: N/A
Checklist: