added footer component and resolve merge conflicts #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rio-react ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
nyandika
suggested changes
Nov 15, 2022
| <footer className="bg-gray-900 text-white"> | ||
| <div className="md:flex md:justify-between md:items-center sm:px-12 px-4 bg-gray-900 py-7"> | ||
| <div> | ||
|
|
| @@ -0,0 +1,21 @@ | |||
|
|
|||
| @@ -0,0 +1,32 @@ | |||
|
|
|||
There was a problem hiding this comment.
Create an interface for the items.
something like this: export interface SomeName{ name: string; link: string }
and then use as: export const Company: SomeName[] = [ { name: "...", link: "..." } ]
This helps with strongly typing stuff
| @@ -0,0 +1,19 @@ | |||
|
|
|||
| @@ -0,0 +1,21 @@ | |||
|
|
|||
| const Item = ({ Links, title }) => { | |||
There was a problem hiding this comment.
lowercase for variable names
| <SocialIcons Icons={Icons} /> | ||
| </div> | ||
| </div> | ||
| <Item Links={Company} title="Company" /> |
There was a problem hiding this comment.
you could include title in interface as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kindly review...