Fix false positive alert with x-default hreflang tag

StJudeWasHere · Feb 19, 2024 · c566ea2 · c566ea2
1 parent cd24f09
commit c566ea2
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 2 deletions.
diff --git a/internal/html_parser/html_parser_test.go b/internal/html_parser/html_parser_test.go
@@ -108,7 +108,7 @@ func TestPageReportHTML(t *testing.T) {
 		{want: 6, got: len(pageReport.Links)},
 		{want: 1, got: len(pageReport.ExternalLinks)},
 		{want: 10, got: pageReport.Words},
-		{want: 1, got: len(pageReport.Hreflangs)},
+		{want: 2, got: len(pageReport.Hreflangs)},
 		{want: 7, got: len(pageReport.Images)},
 		{want: 1, got: len(pageReport.Scripts)},
 		{want: 1, got: len(pageReport.Styles)},

diff --git a/internal/html_parser/testdata/test.html b/internal/html_parser/testdata/test.html
@@ -6,6 +6,7 @@
 		<meta name="robots" content="noindex, nofollow" />
 		<link rel="canonical" href="/canonical/" />
 		<link rel="alternate" href="https://example.com/fr" hreflang="fr" />
+		<link rel="alternate" href="https://example.com/" hreflang="x-default" />
 		<script src="/js/app.js"></script>
 		<link rel="stylesheet" href="/css/style.css">
 	</head>

diff --git a/internal/report_manager/reporters/hreflangs.go b/internal/report_manager/reporters/hreflangs.go
@@ -91,7 +91,7 @@ func NewHreflangMismatchingLang() *report_manager.PageIssueReporter {
 		}
 
 		for _, hl := range pageReport.Hreflangs {
-			if hl.URL == pageReport.URL && hl.Lang != pageReport.Lang {
+			if hl.URL == pageReport.URL && hl.Lang != "x-default" && hl.Lang != pageReport.Lang {
 				return true
 			}
 		}

diff --git a/internal/report_manager/reporters/hreflangs_test.go b/internal/report_manager/reporters/hreflangs_test.go
@@ -150,6 +150,7 @@ func TestHreflangMismatchingLangNoIssues(t *testing.T) {
 		URL:        "http://example.com",
 		Hreflangs: []models.Hreflang{
 			{URL: "http://example.com", Lang: "en"},
+			{URL: "http://example.com", Lang: "x-default"},
 			{URL: "http://example.com/fr", Lang: "fr"},
 		},
 	}
@@ -183,6 +184,7 @@ func TestHreflangMismatchingLangIssues(t *testing.T) {
 		URL:        "http://example.com",
 		Hreflangs: []models.Hreflang{
 			{URL: "http://example.com", Lang: "en"},
+			{URL: "http://example.com", Lang: "x-default"},
 			{URL: "http://example.com/fr", Lang: "fr"},
 		},
 	}