REFACTOR: Opinion: TXT records are one long string #2631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tom Limoncelli <[email protected]>
…2673) Co-authored-by: Tom Limoncelli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This big PR implements an internal change to how TXT records are handled. There should be no user-visible changes.
get-zonesubcommand now generates TAB-separated files that are more correct for TXT records (no quotes).TXT record handling was complex because we abstract them at the wrong layer.
OLD: We try to maintain TXT records as a list of sub-strings, creating complexity at the main level, the diff engine, and the provider level.
NEW: TXT records are stored as a single (possibly very long) string. If a provider's API requires long strings to be split up, joined, escaped, or quoted the provider must handle that internally; it should be invisible to the main code and (more importantly) invisible to the user.