Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNR: Add support for ALIAS record type #3360

Merged
merged 1 commit into from
Jan 14, 2025
Merged

CNR: Add support for ALIAS record type #3360

merged 1 commit into from
Jan 14, 2025
+8 −8

Conversation

AsifNawaz-cnic
Copy link
Contributor

@AsifNawaz-cnic AsifNawaz-cnic commented Jan 14, 2025 •
edited
Loading

The integration tests for DNSControl Alias records were completed successfully.

Here's a detailed summary:

For the domain dnscontroltest2-cnr.com:

  • Various ALIAS records were tested:
  • An ALIAS record was created at the root.
  • The ALIAS record at the root was modified.
  • The ALIAS record at the root was deleted.
  • An ALIAS record pointing to a non-FQDN was created and then deleted.
  • An ALIAS record was created on a subdomain and then modified.
  • The ALIAS record on the subdomain was deleted.
  • Tests for Azure and Route53 ALIAS records were skipped because these features are not supported.
  • All tests passed without any issues.

@AsifNawaz-cnic AsifNawaz-cnic changed the title CNR: Add support for ALIAS record type and update CentralNic Reseller terminology CNR: Add support for ALIAS record type Jan 14, 2025
@AsifNawaz-cnic AsifNawaz-cnic force-pushed the RSRMID-2203-review-extend-the-dns-control-integration branch from 155a738 to f3a60a9 Compare January 14, 2025 12:35
@AsifNawaz-cnic AsifNawaz-cnic marked this pull request as draft January 14, 2025 12:36
@AsifNawaz-cnic AsifNawaz-cnic marked this pull request as ready for review January 14, 2025 12:45
@AsifNawaz-cnic
Copy link
Contributor Author

@KaiSchwarz-cnic Kindly add your feedback regarding the PR if you are okay to approve this PR. thank you

@KaiSchwarz-cnic
Copy link
Contributor

@cafferata / @tlimoncelli I am fine with that PR.

@tlimoncelli
Copy link
Contributor

Most excellent! Thank you for the contribution!

@tlimoncelli tlimoncelli merged commit a3d6c51 into StackExchange:main Jan 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
provider-CNR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AsifNawaz-cnic @KaiSchwarz-cnic @tlimoncelli @cafferata