Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release workflows #451

Merged
merged 40 commits into from
Apr 12, 2021
Merged

Update release workflows #451

merged 40 commits into from
Apr 12, 2021

Conversation

blag
Copy link
Contributor

@blag blag commented Mar 3, 2021

Fix workflows and scripts for the v3.4 release, which required changes to the way the LDAP authentication and RBAC authorization backend plugins are handled.

This includes removing some now-useless bwc workflows, and making the setup_e2e_tests.sh script idempotent, which is very important when you are trying to debug a ST2 instance.

The ChatOps end-to-end tests were skipped on Ubuntu Xenial since they were running into a very weird recursive logging issue - only on Ubuntu Xenial - that we did not see any trace of in user testing. Ubuntu Xenial is EOL in ~1 month anyway, so in the unlikely event that the bug is valid, it is still unlikely that any users will hit it, and if they do, it would be silly for us to support ST2 on an OS that has reached EOL status anyway.

Long live Python 3.6+!

@blag blag added this to the 3.4.0 milestone Mar 3, 2021
@blag
Copy link
Contributor Author

blag commented Mar 3, 2021

This is also a WIP - please DO NOT MERGE.

@blag blag force-pushed the update-release-workflows branch from de845a4 to 3dac3b8 Compare March 4, 2021 06:05
@blag blag force-pushed the update-release-workflows branch from 6036dee to 9741f17 Compare March 4, 2021 06:56
@blag blag force-pushed the update-release-workflows branch from 1063473 to 4541344 Compare March 4, 2021 08:46
Copy link
Contributor

@amanda11 amanda11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - I had a few comments that you may or may not agree with.

actions/setup_e2e_tests.sh Outdated Show resolved Hide resolved
actions/setup_e2e_tests.sh Outdated Show resolved Hide resolved
actions/workflows/st2_chatops_e2e_tests.yaml Outdated Show resolved Hide resolved
@blag blag merged commit 51b0b65 into master Apr 12, 2021
@blag blag deleted the update-release-workflows branch April 12, 2021 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants