-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update release workflows #451
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t responding to WinRM connections at all
|
blag
force-pushed
the
update-release-workflows
branch
from
March 4, 2021 06:05
de845a4
to
3dac3b8
Compare
blag
force-pushed
the
update-release-workflows
branch
from
March 4, 2021 06:56
6036dee
to
9741f17
Compare
blag
force-pushed
the
update-release-workflows
branch
from
March 4, 2021 08:46
1063473
to
4541344
Compare
…st2_auth_backend_pkg workflow
amanda11
reviewed
Mar 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great - I had a few comments that you may or may not agree with.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix workflows and scripts for the v3.4 release, which required changes to the way the LDAP authentication and RBAC authorization backend plugins are handled.
This includes removing some now-useless bwc workflows, and making the
setup_e2e_tests.sh
script idempotent, which is very important when you are trying to debug a ST2 instance.The ChatOps end-to-end tests were skipped on Ubuntu Xenial since they were running into a very weird recursive logging issue - only on Ubuntu Xenial - that we did not see any trace of in user testing. Ubuntu Xenial is EOL in ~1 month anyway, so in the unlikely event that the bug is valid, it is still unlikely that any users will hit it, and if they do, it would be silly for us to support ST2 on an OS that has reached EOL status anyway.
Long live Python 3.6+!