Fix the /paths from absolute to relative in HTMLFix paths #10
Conversation
…ks across the repo
|
|
There was a problem hiding this comment.
Thanks a lot for composing this PR!
Looking at the details and how the URLs change, it seems to get a bit messier than expected considering so many levels for relative path change.
The experiment helps a lot to see all the pros/cons, the real diff and I'm not sure anymore if we should go this way. Curious what others @StackStorm/maintainers think.
At a minimum relevant to this PR, we shouldn't try to link to index.html in the new changes.
| @@ -416,7 +416,7 @@ <h1 class="entry-title">SCALE 12x</h1> | |||
| </div> | |||
|
|
|||
|
|
|||
| <!--googleoff: all--><div id="cookie-law-info-bar" data-nosnippet="true"><span>We use cookies for traffic analytics and ad and content personalization. By clicking on any of the content or interacting with any section of this website,<br>you are agreeing to this use of cookies in the manner described in our <a href="/privacy-policy" id="CONSTANT_OPEN_URL" target="_blank" class="cli-plugin-main-link" style="display:inline-block;">Privacy Policy</a> <a role="button" tabindex="0" data-cli_action="accept" id="cookie_action_close_header" class="cli-plugin-main-button cookie_action_close_header cli_action_button" style="display:inline-block; ">close [x]</a></span></div> | |||
| <!--googleoff: all--><div id="cookie-law-info-bar" data-nosnippet="true"><span>We use cookies for traffic analytics and ad and content personalization. By clicking on any of the content or interacting with any section of this website,<br>you are agreeing to this use of cookies in the manner described in our <a href="../../../../privacy-policy/index.html" id="CONSTANT_OPEN_URL" target="_blank" class="cli-plugin-main-link" style="display:inline-block;">Privacy Policy</a> <a role="button" tabindex="0" data-cli_action="accept" id="cookie_action_close_header" class="cli-plugin-main-button cookie_action_close_header cli_action_button" style="display:inline-block; ">close [x]</a></span></div> | |||
There was a problem hiding this comment.
Yeah, that's a lot of levels for the relative path ...
-<a href="/privacy-policy"
+<a href="../../../../privacy-policy/index.html"| @@ -337,57 +337,57 @@ <h1 class="entry-title">[SDX Central] StackStorm Takes A Modernized Shot At DevO | |||
| <section id="text-7" class="col"><div class="scn"> <div class="textwidget"> | |||
| <p><a href="http://docs.stackstorm.com/" target="_blank" rel="noopener">Documentation</a><br> | |||
| <a href="https://github.com/StackStorm" target="_blank" rel="noopener">GitHub</a><br> | |||
| <a href="/#community" target="_blank" rel="noopener">Community</a><br> | |||
| <a href="/security" target="_blank" rel="noopener">Security</a></p> | |||
| <a href="../../../../index.html#community" target="_blank" rel="noopener">Community</a><br> | |||
There was a problem hiding this comment.
Oh well.
Yeah, I see it's getting messy.
| </div> | ||
| </div></section> </div> | ||
| <div class="colm oth "> | ||
| <section id="text-8" class="col"><div class="scn"> <div class="textwidget"> | ||
| <p><a href="/blog">Blog</a><br> | ||
| <p><a href="../../../../blog/index.html">Blog</a><br> |
There was a problem hiding this comment.
At minimum we shouldn't point to index.html in any case as that part should be hidden
| <p><a href="../../../../blog/index.html">Blog</a><br> | |
| <p><a href="../../../../blog">Blog</a><br> |
There was a problem hiding this comment.
Makes sense.
The code base is plain HTML/JS/CSS, so I believe there aren't much options for resolving URL paths and for hiding the filename while still having the links work. We could technically create a global variable that yields the root directory's path and share it across all the files using a <script> tag, but that will only make the codebase messier and more difficult to maintain, since every src and href value would need to be injected via JS. Of course, even then the website would break on JavaScript disabled browsers.
If this codebase is a part of some kind of framework when ported to your testing/production environment - something that can handle dynamic values across the files - then I believe the solution should become much simpler.
I'm not yet an experienced developer (just about 2 years under my belt) and this is my first ever open source contribution, so please feel free to correct me wherever I'm wrong. Appreciate your comments. A big thanks for reviewing my contribution.
Fixes #5
A few caveats/heads-up/feedback:
#communityURL fragment is linked with atarget="_blank"attribute, which could still make sense for other pages, but on the home page that the fragment belongs to, it looks weird./2021/12/16/stackstorm-v3-6-0-released/[email protected]). I left it as it is. Not sure if there are more like that./start-now/and/news-events/) mostly directly below the root level. I have fixed the relative path for them anyway. I haven't found/made a note of all such broken links./meeting-registration-tuesday-july-22-1130-pdtat/2014/07/23/stackstorm-devops-automation-interactive-webinars-register-today/index.html. I have fixed their relative paths as well, FWIW.wp-jsondirectory/file in so many<link>tags across the codebase, but never within an<a>tag. I left it as it is.