Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcode 16.2 / iOS 18.2 support #121

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Xcode 16.2 / iOS 18.2 support #121

merged 1 commit into from
Jan 6, 2025

Conversation

lukaskollmer
Copy link
Member

Xcode 16.2 / iOS 18.2 support

♻️ Current situation & Problem

The app currently doesn't compile with Xcode 16.2, because some dependencies need to be updated to handle the onPreferenceChange API changes.

⚙️ Release Notes

  • Add Xcode 16.2 support

📚 Documentation

n/a

✅ Testing

n/a

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.49%. Comparing base (532d7e7) to head (f7929f4).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
- Coverage   79.05%   78.49%   -0.56%     
==========================================
  Files         149      149              
  Lines        5112     5155      +43     
==========================================
+ Hits         4041     4046       +5     
- Misses       1071     1109      +38     

see 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 914e5dc...f7929f4. Read the comment docs.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lukaskollmer! 🚀

@PSchmiedmayer PSchmiedmayer added the enhancement New feature or request label Jan 6, 2025
@PSchmiedmayer PSchmiedmayer merged commit ed34e80 into main Jan 6, 2025
7 checks passed
@PSchmiedmayer PSchmiedmayer deleted the lukas/xcode-16.2 branch January 6, 2025 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants