-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Diagnostics types from Management.Abstractions to Management.Endpoint #1424
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,4 @@ | ||
#nullable enable | ||
abstract Steeltoe.Management.Diagnostics.DiagnosticObserver.ProcessEvent(string! eventName, object? value) -> void | ||
Steeltoe.Management.Configuration.EndpointOptions | ||
Steeltoe.Management.Configuration.EndpointOptions.AllowedVerbs.get -> System.Collections.Generic.IList<string!>! | ||
Steeltoe.Management.Configuration.EndpointOptions.EndpointOptions() -> void | ||
|
@@ -9,42 +8,6 @@ Steeltoe.Management.Configuration.EndpointPermissions | |
Steeltoe.Management.Configuration.EndpointPermissions.Full = 2 -> Steeltoe.Management.Configuration.EndpointPermissions | ||
Steeltoe.Management.Configuration.EndpointPermissions.None = 0 -> Steeltoe.Management.Configuration.EndpointPermissions | ||
Steeltoe.Management.Configuration.EndpointPermissions.Restricted = 1 -> Steeltoe.Management.Configuration.EndpointPermissions | ||
Steeltoe.Management.Diagnostics.DiagnosticObserver | ||
Steeltoe.Management.Diagnostics.DiagnosticObserver.DiagnosticObserver(string! name, string! listenerName, Microsoft.Extensions.Logging.ILoggerFactory! loggerFactory) -> void | ||
Steeltoe.Management.Diagnostics.DiagnosticObserver.Dispose() -> void | ||
Steeltoe.Management.Diagnostics.DiagnosticObserver.ListenerName.get -> string! | ||
Steeltoe.Management.Diagnostics.DiagnosticObserver.ObserverName.get -> string! | ||
Steeltoe.Management.Diagnostics.DiagnosticObserver.Subscribe(System.Diagnostics.DiagnosticListener! listener) -> void | ||
Steeltoe.Management.Diagnostics.IDiagnosticObserver | ||
Steeltoe.Management.Diagnostics.IDiagnosticObserver.ObserverName.get -> string! | ||
Steeltoe.Management.Diagnostics.IDiagnosticObserver.Subscribe(System.Diagnostics.DiagnosticListener! listener) -> void | ||
Steeltoe.Management.Diagnostics.IDiagnosticsManager | ||
Steeltoe.Management.Diagnostics.IDiagnosticsManager.Start() -> void | ||
Steeltoe.Management.Diagnostics.IDiagnosticsManager.Stop() -> void | ||
Steeltoe.Management.Diagnostics.IRuntimeDiagnosticSource | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think there's an argument (though probably undocument) in there somewhere for making There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What would that argument be? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Basically the same as |
||
Steeltoe.Management.Diagnostics.IRuntimeDiagnosticSource.AddInstrumentation() -> void | ||
Steeltoe.Management.Diagnostics.MetricsObserverOptions | ||
Steeltoe.Management.Diagnostics.MetricsObserverOptions.AspNetCoreHosting.get -> bool | ||
Steeltoe.Management.Diagnostics.MetricsObserverOptions.AspNetCoreHosting.set -> void | ||
Steeltoe.Management.Diagnostics.MetricsObserverOptions.EgressIgnorePattern.get -> string? | ||
Steeltoe.Management.Diagnostics.MetricsObserverOptions.EgressIgnorePattern.set -> void | ||
Steeltoe.Management.Diagnostics.MetricsObserverOptions.EventCounterEvents.get -> bool | ||
Steeltoe.Management.Diagnostics.MetricsObserverOptions.EventCounterEvents.set -> void | ||
Steeltoe.Management.Diagnostics.MetricsObserverOptions.EventCounterIntervalSec.get -> int? | ||
Steeltoe.Management.Diagnostics.MetricsObserverOptions.EventCounterIntervalSec.set -> void | ||
Steeltoe.Management.Diagnostics.MetricsObserverOptions.ExcludedMetrics.get -> System.Collections.Generic.IList<string!>! | ||
Steeltoe.Management.Diagnostics.MetricsObserverOptions.GCEvents.get -> bool | ||
Steeltoe.Management.Diagnostics.MetricsObserverOptions.GCEvents.set -> void | ||
Steeltoe.Management.Diagnostics.MetricsObserverOptions.HttpClientCore.get -> bool | ||
Steeltoe.Management.Diagnostics.MetricsObserverOptions.HttpClientCore.set -> void | ||
Steeltoe.Management.Diagnostics.MetricsObserverOptions.HttpClientDesktop.get -> bool | ||
Steeltoe.Management.Diagnostics.MetricsObserverOptions.HttpClientDesktop.set -> void | ||
Steeltoe.Management.Diagnostics.MetricsObserverOptions.IncludedMetrics.get -> System.Collections.Generic.IList<string!>! | ||
Steeltoe.Management.Diagnostics.MetricsObserverOptions.IngressIgnorePattern.get -> string? | ||
Steeltoe.Management.Diagnostics.MetricsObserverOptions.IngressIgnorePattern.set -> void | ||
Steeltoe.Management.Diagnostics.MetricsObserverOptions.MetricsObserverOptions() -> void | ||
Steeltoe.Management.Diagnostics.MetricsObserverOptions.ThreadPoolEvents.get -> bool | ||
Steeltoe.Management.Diagnostics.MetricsObserverOptions.ThreadPoolEvents.set -> void | ||
virtual Steeltoe.Management.Configuration.EndpointOptions.Enabled.get -> bool? | ||
virtual Steeltoe.Management.Configuration.EndpointOptions.Enabled.set -> void | ||
virtual Steeltoe.Management.Configuration.EndpointOptions.GetDefaultAllowedVerbs() -> System.Collections.Generic.IList<string!>! | ||
|
@@ -53,7 +16,3 @@ virtual Steeltoe.Management.Configuration.EndpointOptions.Id.set -> void | |
virtual Steeltoe.Management.Configuration.EndpointOptions.Path.get -> string? | ||
virtual Steeltoe.Management.Configuration.EndpointOptions.Path.set -> void | ||
virtual Steeltoe.Management.Configuration.EndpointOptions.RequiresExactMatch() -> bool | ||
virtual Steeltoe.Management.Diagnostics.DiagnosticObserver.Dispose(bool disposing) -> void | ||
virtual Steeltoe.Management.Diagnostics.DiagnosticObserver.OnCompleted() -> void | ||
virtual Steeltoe.Management.Diagnostics.DiagnosticObserver.OnError(System.Exception! error) -> void | ||
virtual Steeltoe.Management.Diagnostics.DiagnosticObserver.OnNext(System.Collections.Generic.KeyValuePair<string!, object?> value) -> void |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we still need
DiagnosticObserver
then I think it (andIDiagnosticObserver
) should stay in the Abstractions package for extensibilityThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if we still need them, they remain public and extensible. But it is only used by the metrics actuator, so close to that seems the better place to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keeping it in Abstractions would be better if (as an example) we wanted to add a
DiagnosticObserver
for Eureka. Sure it's only used by the endpoint, but another implementation likely wouldn't be in an application and might not want the heavier dependency on Endpoint