Use structlog filter for status endpoints

Striveworks · Feb 12, 2024 · ab2a1fd · ab2a1fd
1 parent 8523d50
commit ab2a1fd
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/api/velour_api/__init__.py b/api/velour_api/__init__.py
@@ -9,8 +9,23 @@
     logging_level = 20
 
 
+def status_endpoint_filter(
+    logger,
+    method_name,
+    event_dict,
+    ignore_paths=frozenset(["/health", "/ready"]),
+):
+    if (
+        event_dict.get("path", "") in ignore_paths
+        and event_dict.get("status", 0) == 200
+    ):
+        raise structlog.DropEvent
+    return event_dict
+
+
 structlog.configure(
     processors=[
+        status_endpoint_filter,
         structlog.processors.add_log_level,
         structlog.processors.TimeStamper(fmt="iso"),
         structlog.processors.dict_tracebacks,

diff --git a/api/velour_api/logging.py b/api/velour_api/logging.py
@@ -11,10 +11,7 @@
 def log_endpoint(
     request: Request,
     status_code: Optional[int],
-    ignore_paths=frozenset(["/health", "/ready"]),
 ):
-    if request.url.path in ignore_paths and status_code == 200:
-        return
     logger.info(
         "Velour API Call",
         method=request.method,